[esnacc-dev] [PATCH] Change EXTERNAL.single-ASN1-type from OCTET STRING to ANY

[Aaron Conole]

Hi Vasil,

Vasil Velichkov <vvvelichkov at gmail.com> writes:

> From "ITU Recommendation X.208"
>
>   34.4 The EXTERNAL type can be defined, using ASN.1, as follows:
>   EXTERNAL ::= [UNIVERSAL 8] IMPLICIT SEQUENCE
>   {direct-reference OBJECT IDENTIFIER OPTIONAL,
>   indirect-reference INTEGER OPTIONAL,
>   data-value-descriptor ObjectDescriptor OPTIONAL,
>   encodingCHOICE
>     {single-ASN1-type [0] ANY,
>     octet-aligned [1] IMPLICIT OCTET STRING,
>     arbitrary [2] IMPLICIT BIT STRING}}
> ---

First, thanks for this contribution.  I'll apply this change with your
signoff as follows:

  Signed-off-by: Vasil Velichkov <vvvelichkov at gmail.com>

And I'll add you to the AUTHORS file.

I will need to give a final fixup to the parser to properly generate the
types from this file.

Since this change will eventually cause an ABI breakage, I think it might be
best to wait on input from Sagara.  I agree it's good to apply this, but
the logistics about upgrades / downgrades when linked also need to be
considered;  we will likely have to increment the abi version and let
folks deal with the fallout.

Thanks for the understanding, and for the contribution!  It won't rot on
the list.

-Aaron