[esnacc-dev] [PATCH 0/2] Drop VDAThreads support
Aaron Conole
aconole at bytheb.org
Wed Mar 22 13:09:12 UTC 2017
Sagara Wickramasekara <sagaraw at gmail.com> writes:
> Reviewed code and tried it out an older Ubuntu (10.04) system
>
> Reviewed-by: Sagara Wickramasekara <sagaraw at gmail.com>
Thanks, Sagara. Applied.
> On Thu, Mar 16, 2017 at 5:03 PM, Aaron Conole <aconole at bytheb.org> wrote:
>
> After looking at this code for a while, it seems like we support a
> framework that doesn't make sense to maintain. I've double checked
> with one of the original contributors to this code (Pierce Leonberger)
> and this is what he had to say:
>
> ...if I remember correctly vda_threads was a multi-threading
> abstraction layer we developed so the code within eSNACC
> wouldn't have to change from OS to OS.
>
> Since multithreading abstraction is provided by default in C++11, and
> since the esnacc compiler doesn't use these abstractions *anyway*
> (seriously, I just deleted references to things - all the insertions are
> in 2/2 where we need to change lines to remove continuation backslashes!),
> I'm removing them.
>
> Since it's all deletes, this series has some *tremendous* patch statistics.
>
> I've validated this on a Fedora 25 system - but testing on OSX, Ubuntu,
> and windows hosts would be appreciated.
>
> Aaron Conole (2):
> cxx-lib: remove vdathread support
> pthread: drop pthread requirement
>
> appveyor.yml | 15 +-
> c-lib/automake.mk | 1 -
> configure.ac | 1 -
> cxx-examples/automake.mk | 10 +-
> cxx-lib/automake.mk | 8 +-
> cxx-lib/inc/asn-incl.h | 3 -
> cxx-lib/src/asn-any.cpp | 4 -
> cxx-lib/src/vda_threads2.cpp | 94 --------
> doc/developer-guide-sample-app.md | 2 +-
> m4/ax_pthread.m4 | 485 --------------------------------------
> m4/windows.m4 | 26 --
> 11 files changed, 6 insertions(+), 643 deletions(-)
> delete mode 100644 cxx-lib/src/vda_threads2.cpp
> delete mode 100644 m4/ax_pthread.m4
>
> --
> 2.9.3
>
> _______________________________________________
> dev mailing list
> dev at lists.esnacc.org
> http://mail.esnacc.org/mailman/listinfo/dev
More information about the dev
mailing list