[esnacc-dev] [PATCH v2] build: Do not fail build if xsltproc is missing

Sagara Wickramasekara sagaraw at gmail.com
Mon Nov 13 11:55:46 UTC 2017


Acked-by: Sagara Wickramasekara <sagaraw at gmail.com>

On Thu, Nov 2, 2017 at 2:51 PM, Aaron Conole <aconole at bytheb.org> wrote:

> From: Vegar Westerlund <vegarwe at gmail.com>
>
> As a side-effect this makes it possible to compile without
> having network access (since xsltproc needs to go online to
> fetch some xml).
>
> Signed-off-by: Vegar Westerlund <vegarwe at gmail.com>
> Signed-off-by: Aaron Conole <aconole at bytheb.org>
> ---
> v1->v2: The && condition was always creating a failure case.
>
>  compiler/automake.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/compiler/automake.mk b/compiler/automake.mk
> index dd59446..b5bab03 100644
> --- a/compiler/automake.mk
> +++ b/compiler/automake.mk
> @@ -92,7 +92,8 @@ DISTCLEANFILES += compiler/esnacc.1
>  endif
>
>  compiler/esnacc.1: compiler/esnacc.xml
> -       $(XSLTPROC) --novalid -o $@ $(DOCBOOK_LOCATION) $<
> +       @test -x "$(XSLTPROC)" && $(XSLTPROC) --novalid -o $@
> $(DOCBOOK_LOCATION) $<; true
> +       @test -x "$(XSLTPROC)" || echo "Not generating documentation,
> xsltproc missing"
>
>  CLEANFILES += compiler/core/lex-asn1.c \
>         compiler/core/y.output \
> --
> 2.9.5
>
> _______________________________________________
> dev mailing list
> dev at lists.esnacc.org
> http://mail.esnacc.org/mailman/listinfo/dev
>



-- 
-Sagara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.esnacc.org/pipermail/dev/attachments/20171113/8abdc85d/attachment.html>


More information about the dev mailing list