<div dir="ltr">Hello,<div>Thanks, next time I will open sign feature in git .</div><div><br></div><div>Signed-off-by: Si Peng <<a href="mailto:stiffme@gmail.com">stiffme@gmail.com</a>><br></div><div><br></div><div>Best regards,</div><div>Si Peng</div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-08-23 22:05 GMT+08:00 Aaron Conole <span dir="ltr"><<a href="mailto:aconole@redhat.com" target="_blank">aconole@redhat.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Hi Si,<br>
<br>
General comments - it is usually preferable to use git send-email with<br>
the patch files. I don't see a signed-off-by line in your patches - we<br>
need this to confirm that you accept the licensing terms. That is<br>
described in the top-level CONTRIBUTING.md guide.<br>
<br>
If you reply-all to this message with a signed-off-by tag, I'll add it.<br>
<br>
Did you also want this backported to branch-1.8? It looks like a good<br>
candidate, and I'm not opposed. I'll apply after I get your responses.<br>
<span class=""><br>
<<a href="mailto:stiffme@gmail.com">stiffme@gmail.com</a>> writes:<br>
<br>
<br>
> >From 64fc4024472ebb70e84e17b2b7419c<wbr>e0da350173 Mon Sep 17 00:00:00 2001<br>
</span>> From: stiffme <stiffme at <a href="http://gmail.com" rel="noreferrer" target="_blank">gmail.com</a>><br>
<span class="">> Date: Sun, 21 Aug 2016 18:55:07 +0800<br>
> Subject: [PATCH 1/4] Fix crash when extension is used in child tags<br>
><br>
> Extension type has no tags, this will cause :<br>
> tag = (Tag*)FIRST_LIST_ELMT (tl);<br>
> crash.<br>
> ---<br>
> compiler/back-ends/tag-util.c | 4 +++-<br>
> 1 file changed, 3 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/compiler/back-ends/tag-util.<wbr>c b/compiler/back-ends/tag-util.<wbr>c<br>
> index fa2d2d7..3e7d30f 100644<br>
> --- a/compiler/back-ends/tag-util.<wbr>c<br>
> +++ b/compiler/back-ends/tag-util.<wbr>c<br>
> @@ -191,7 +191,9 @@ GetTags PARAMS ((t, stoleChoiceTags),<br>
><br>
> if (tl == NULL)<br>
> break;<br>
> -<br>
> + if(e->type->basicType-><wbr>choiceId == BASICTYPE_EXTENSION)<br>
> + continue;<br>
> +<br>
<br>
</span>No need for the trailing white space on this line.<br>
<span class=""><br>
> AsnListFirst (tl);<br>
> if (stoleChoicesAgain)<br>
> {<br>
><br>
> >From bbcf1b167f49309f97c31a56a5c396<wbr>6237070bae Mon Sep 17 00:00:00 2001<br>
</span>> From: stiffme <stiffme at <a href="http://gmail.com" rel="noreferrer" target="_blank">gmail.com</a>><br>
<span class="">> Date: Mon, 22 Aug 2016 09:52:51 +0800<br>
> Subject: [PATCH 2/4] Update AUTHORS<br>
><br>
> ---<br>
> AUTHORS | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/AUTHORS b/AUTHORS<br>
> index f2796b2..a03aea1 100644<br>
> --- a/AUTHORS<br>
> +++ b/AUTHORS<br>
> @@ -32,7 +32,7 @@ Scott Rankin<br>
> Tom Horvath<br>
> Uri Blumenthal <a href="mailto:uri@mit.edu">uri@mit.edu</a><br>
> Vladislav Evgeniev<br>
> -<br>
> +Si Peng <a href="mailto:stiffme@gmail.com">stiffme@gmail.com</a><br>
<br>
</span>I'll take this hunk, fold it into the previous, and apply as a single<br>
patch. I'll also move it so that it is alphabetical. Please<br>
acknowledge that my proposal is acceptable.<br>
<span class=""><br>
><br>
> REPORTERS<br>
> =========<br>
><br>
> >From b746b146d5b39074c2019b17770b60<wbr>c05d0bcd81 Mon Sep 17 00:00:00 2001<br>
</span>> From: stiffme <stiffme at <a href="http://gmail.com" rel="noreferrer" target="_blank">gmail.com</a>><br>
<div><div class="h5">> Date: Mon, 22 Aug 2016 09:59:39 +0800<br>
> Subject: [PATCH 3/4] Update tag-util.c<br>
><br>
> ---<br>
> compiler/back-ends/tag-util.c | 7 +++++--<br>
> 1 file changed, 5 insertions(+), 2 deletions(-)<br>
><br>
> diff --git a/compiler/back-ends/tag-util.<wbr>c b/compiler/back-ends/tag-util.<wbr>c<br>
> index 3e7d30f..0eba1e3 100644<br>
> --- a/compiler/back-ends/tag-util.<wbr>c<br>
> +++ b/compiler/back-ends/tag-util.<wbr>c<br>
> @@ -10,8 +10,11 @@<br>
> * the Free Software Foundation; either version 2 of the License, or<br>
> * (at your option) any later version.<br>
> *<br>
> - * $Header: /baseline/SNACC/compiler/back-<wbr>ends/tag-util.c,v 1.7<br>
> 2003/07/28 11:13:51 colestor Exp $<br>
> + * $Header: /baseline/SNACC/compiler/back-<wbr>ends/tag-util.c,v1.8<br>
> 2016/08/22 Si Peng Exp $<br>
> * $Log: tag-util.c,v $<br>
> + * Revision 1.8 2016/08/22 Si Peng<br>
> + * Fix a crash when implicit tags are used and child top level tag<br>
> contains "...".<br>
> + *<br>
> * Revision 1.7 2003/07/28 11:13:51 colestor<br>
> * Changes to complete handing of the "--snacc namespace" compiler directive.<br>
> * Also, updates to handle ASN.1 constant integer tag designations for C++/C.<br>
> @@ -85,7 +88,7 @@<br>
> * { {<br>
> * foo [0] INTEGER, [0] INTEGER,<br>
> * bar SomeChoice, [1] BOOLEAN,<br>
> - * bell [1] IMPLICIT BOOLEAN, [2] IA5String<br>
> + * bell [1] IMPLICIT BOOLEAN, [2] IA5String,<br>
> * gumby [2] SomeChoice, }<br>
> poki SomeOtherChoice<br>
> * }<br>
><br>
> >From 5b88652ba7942ca044469f873dae6a<wbr>5ee90d19b6 Mon Sep 17 00:00:00 2001<br>
</div></div>> From: stiffme <stiffme at <a href="http://gmail.com" rel="noreferrer" target="_blank">gmail.com</a>><br>
<div><div class="h5">> Date: Mon, 22 Aug 2016 10:01:45 +0800<br>
> Subject: [PATCH 4/4] Update tag-util.c<br>
><br>
> Added version information,<br>
> Changed example of implicit tags<br>
> ---<br>
> compiler/back-ends/tag-util.c | 6 +++---<br>
> 1 file changed, 3 insertions(+), 3 deletions(-)<br>
><br>
> diff --git a/compiler/back-ends/tag-util.<wbr>c b/compiler/back-ends/tag-util.<wbr>c<br>
> index 0eba1e3..b7c4d0a 100644<br>
> --- a/compiler/back-ends/tag-util.<wbr>c<br>
> +++ b/compiler/back-ends/tag-util.<wbr>c<br>
> @@ -10,7 +10,7 @@<br>
> * the Free Software Foundation; either version 2 of the License, or<br>
> * (at your option) any later version.<br>
> *<br>
> - * $Header: /baseline/SNACC/compiler/back-<wbr>ends/tag-util.c,v1.8<br>
> 2016/08/22 Si Peng Exp $<br>
> + * $Header: /baseline/SNACC/compiler/back-<wbr>ends/tag-util.c,v 1.8<br>
> 2016/08/22 Si Peng Exp $<br>
> * $Log: tag-util.c,v $<br>
> * Revision 1.8 2016/08/22 Si Peng<br>
> * Fix a crash when implicit tags are used and child top level tag<br>
> contains "...".<br>
> @@ -89,8 +89,8 @@<br>
> * foo [0] INTEGER, [0] INTEGER,<br>
> * bar SomeChoice, [1] BOOLEAN,<br>
> * bell [1] IMPLICIT BOOLEAN, [2] IA5String,<br>
> - * gumby [2] SomeChoice, }<br>
> - poki SomeOtherChoice<br>
> + * gumby [2] SomeChoice, ...<br>
> + * poki SomeOtherChoice }<br>
> * }<br>
> *<br>
> * SomeOtherChoice ::= [APPLICATION 99] CHOICE { ....}<br>
<br>
</div></div>I'll merge part of these changes together.<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Best regards,<br>Stanley Peng</div>
</div>