<div dir="ltr"><div><span style="font-size:12.8px"><span class="gmail-m_2988522382811098511gmail-m_1972589155236975156gmail-m_-5847411734849609326gmail-il">Reviewed code and tried it out an older Ubuntu (10.04) system</span></span></div><div><span style="font-size:12.8px"><span class="gmail-m_2988522382811098511gmail-m_1972589155236975156gmail-m_-5847411734849609326gmail-il"><br></span></span></div><div><span style="font-size:12.8px"><span class="gmail-m_2988522382811098511gmail-m_1972589155236975156gmail-m_-5847411734849609326gmail-il">Reviewed</span>-<span class="gmail-m_2988522382811098511gmail-m_1972589155236975156gmail-m_-5847411734849609326gmail-il">by</span>: Sagara Wickramasekara <</span><a style="font-size:12.8px" href="mailto:sagaraw@gmail.com" target="_blank">sagaraw@gmail.<wbr>com</a><span style="font-size:12.8px">></span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 16, 2017 at 5:03 PM, Aaron Conole <span dir="ltr"><<a href="mailto:aconole@bytheb.org" target="_blank">aconole@bytheb.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">After looking at this code for a while, it seems like we support a<br>
framework that doesn't make sense to maintain. I've double checked<br>
with one of the original contributors to this code (Pierce Leonberger)<br>
and this is what he had to say:<br>
<br>
...if I remember correctly vda_threads was a multi-threading<br>
abstraction layer we developed so the code within eSNACC<br>
wouldn't have to change from OS to OS.<br>
<br>
Since multithreading abstraction is provided by default in C++11, and<br>
since the esnacc compiler doesn't use these abstractions *anyway*<br>
(seriously, I just deleted references to things - all the insertions are<br>
in 2/2 where we need to change lines to remove continuation backslashes!),<br>
I'm removing them.<br>
<br>
Since it's all deletes, this series has some *tremendous* patch statistics.<br>
<br>
I've validated this on a Fedora 25 system - but testing on OSX, Ubuntu,<br>
and windows hosts would be appreciated.<br>
<br>
Aaron Conole (2):<br>
cxx-lib: remove vdathread support<br>
pthread: drop pthread requirement<br>
<br>
appveyor.yml | 15 +-<br>
c-lib/<a href="http://automake.mk" target="_blank" rel="noreferrer">automake.mk</a> | 1 -<br>
<a href="http://configure.ac" target="_blank" rel="noreferrer">configure.ac</a> | 1 -<br>
cxx-examples/<a href="http://automake.mk" target="_blank" rel="noreferrer">automake.mk</a> | 10 +-<br>
cxx-lib/<a href="http://automake.mk" target="_blank" rel="noreferrer">automake.mk</a> | 8 +-<br>
cxx-lib/inc/asn-incl.h | 3 -<br>
cxx-lib/src/asn-any.cpp | 4 -<br>
cxx-lib/src/vda_threads2.cpp | 94 --------<br>
doc/<a href="http://developer-guide-sample-app.md" target="_blank" rel="noreferrer">developer-guide-sample-<wbr>app.md</a> | 2 +-<br>
m4/ax_pthread.m4 | 485 ------------------------------<wbr>--------<br>
m4/windows.m4 | 26 --<br>
11 files changed, 6 insertions(+), 643 deletions(-)<br>
delete mode 100644 cxx-lib/src/vda_threads2.cpp<br>
delete mode 100644 m4/ax_pthread.m4<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
2.9.3<br>
<br>
______________________________<wbr>_________________<br>
dev mailing list<br>
<a href="mailto:dev@lists.esnacc.org">dev@lists.esnacc.org</a><br>
<a href="http://mail.esnacc.org/mailman/listinfo/dev" target="_blank" rel="noreferrer">http://mail.esnacc.org/<wbr>mailman/listinfo/dev</a><br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">-Sagara</div>
</div>