<!DOCTYPE html>
<html><head>
<meta charset="UTF-8">
</head><body><p class="io-ox-signature">Are you planning to push this to master? Or do I need to ACK the change, or is it just on one branch (which one)?</p><p class="io-ox-signature"><br></p><p class="io-ox-signature">--<br>-Marty Galligan, m_galligan@comcast.net, c: 978-505-5185</p><p><br></p><blockquote><p>On July 25, 2017 at 10:44 AM Aaron Conole <aconole@bytheb.org> wrote:</p><p>When cross-compiling the system, it is not possible for the esnacc binary to<br>correctly execute on the build system (well, not always). There is a<br>method to combat this, which is the approach gcc takes, to generate a stage<br>one version of the compiler and then execute that to generate the final<br>tools (stage 2). That represents quite a bit of work.</p><p>On the other hand, people are using esnacc *now* and as Marty Galligan<br>reports at <a href="http://mail.esnacc.org/pipermail/dev/2017-July/000414.html">http://mail.esnacc.org/pipermail/dev/2017-July/000414.html</a> there<br>can be problems cross building, especially related to this.</p><p>This commit detects that a cross-compilation is occuring and disables the<br>generation of the asn.1 ROSE support. A future commit can enable this<br>when it becomes necessary.</p><p>Reported-by: Marty Galligan <m_galligan@comcast.net></p><p>Signed-off-by: Aaron Conole <aconole@bytheb.org></p><p>---<br> configure.ac | 4 ++++<br> cxx-lib/automake.mk | 9 ++++++---<br> 2 files changed, 10 insertions(+), 3 deletions(-)</p><p>diff --git a/configure.ac b/configure.ac<br>index 26007ef..65b4b48 100644<br>--- a/configure.ac<br>+++ b/configure.ac<br>@@ -32,6 +32,10 @@ AC_PROG_INSTALL<br> AM_INIT_AUTOMAKE([-Wall foreign subdir-objects])<br> AC_PROG_CC<br> AC_PROG_CXX<br>+<br>+AM_CONDITIONAL([SNACCROSE], [test "$cross_compiling" = no])<br>+test x"$cross_compiling" == xyes && AC_DEFINE([SNACCROSE], [0], [No ROSE support])<br>+<br> AM_PATH_PYTHON(,, [:])<br> AM_CONDITIONAL([HAVE_PYTHON], [test "$PYTHON" != :])<br> AC_USE_SYSTEM_EXTENSIONS<br>diff --git a/cxx-lib/automake.mk b/cxx-lib/automake.mk<br>index 2c5b7ea..fc841ca 100644<br>--- a/cxx-lib/automake.mk<br>+++ b/cxx-lib/automake.mk<br>@@ -1,5 +1,9 @@<br>-lib_LTLIBRARIES += cxx-lib/libcxxasn1.la \</p><ul><li><p>cxx-lib/libcxxasn1rose.la<br>+lib_LTLIBRARIES += cxx-lib/libcxxasn1.la<br>+<br>+if SNACCROSE<br>+lib_LTLIBRARIES += cxx-lib/libcxxasn1rose.la<br>+nobase_include_HEADERS += cxx-lib/inc/snaccrose.h<br>+endif</p><p>BUILT_SOURCES += cxx-lib/inc/snacc.h</p></li></ul><p>@@ -17,7 +21,6 @@ nobase_include_HEADERS += cxx-lib/inc/asn-buf.h \<br> cxx-lib/inc/snacc.h \<br> cxx-lib/inc/snaccdll.h \<br> cxx-lib/inc/snaccexcept.h \</p><ul><li><p>cxx-lib/inc/snaccrose.h \<br>cxx-lib/inc/tcl-if.h</p><p>cxx_lib_libcxxasn1_la_SOURCES = \<br>--<br>2.9.4</p></li></ul><p>_______________________________________________<br>dev mailing list<br>dev@lists.esnacc.org<br><a href="http://mail.esnacc.org/mailman/listinfo/dev">http://mail.esnacc.org/mailman/listinfo/dev</a></p></blockquote></body></html>