[pw-ci] [RFC v3 0/2] pw-ci: update mon scripts to process multiple workflows

Salvatore Daniele sdaniele at redhat.com
Thu Jul 29 21:36:03 UTC 2021


Currently, github monitor only expects to process a single workflow.
This worked as an initial implementation. 

However, this fails in the event there are multiple workflows for a
single patch, such as in the case of ovsrobot/ovn where there is a 
"build and test" workflow and "ovn-kubernetes" workflow.

Additionally, the ovn-kubernetes workflow can have multiple steps fail
for a single job. This breaks github_get_logs.sh, which currently only
expects a single step to fail per job.

The first patch tries to address the former by changing github_mon to
run a scan for any arbitrary number of workflows it may recieve and
return the results to ci_mon to generate a report for each workflow.

The second patch addresses the latter by updating github_get_logs.sh to
accept an arbitrary number of failed steps for any given job.


The reports generated by this change looks as expected with the
exception of the following error:

series_get() called in ci_mon is returning
"Series 254779 not found for instance patchwork.ozlabs.org", due to
series_id_exists() returning false. 

I am not sure what change to the scripts would cause this error, or if
it existed previously, but I will continue to investigate. 
Alternatively, it could be due to my local testing set up, so any 
additional testing of this patch would be very much appreciated. 


v3
- Fix commit message
- Small typos
v2
- Address inital comments made by Aaron C on v1
- Add additional patch to series to fix bug identified by Michael S



Salvatore Daniele (2):
  github: support respositories with multiple workflows
  github_get_logs: handle multiple failed step in a single job

 ci_mon             | 12 +++++++++---
 github_get_logs.sh | 20 +++++++++++++-------
 github_mon         | 37 ++++++++++++++++++++++++++-----------
 3 files changed, 48 insertions(+), 21 deletions(-)

-- 
2.31.1



More information about the Pwci mailing list